Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 fix: fix external link icon breaking word wrapping #498

Merged
merged 1 commit into from
Mar 15, 2025

Conversation

welpo
Copy link
Owner

@welpo welpo commented Mar 15, 2025

Summary

This PR fixes the external link icon breaking word wrapping on long link text. Previously, links with the external icon would be treated as a single unbreakable unit, causing awkward line breaks.

Related issue

Fixes #495

Changes

The root cause was the display: inline-block property applied to external links. This change:

  • Removes the display: inline-block property from external links
  • Adjusts the icon implementation to use inline-block only on the pseudo-element

Accessibility

Unaffected/improved.

Screenshots

Before

bbefore

After

aafter

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have updated config.toml in tabi-start
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@welpo welpo added the bug Something isn't working label Mar 15, 2025
Copy link

netlify bot commented Mar 15, 2025

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 9dfef5c
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/67d54043bcda8b0008755e2f
😎 Deploy Preview https://deploy-preview-498--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo welpo changed the title 💄fix: fix external link icon breaking word wrapping 💄 fix: fix external link icon breaking word wrapping Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External link icon breaks word wrapping on long link text
1 participant