irc: restore away status and message when connecting to away ZNC (#1059) #1302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #1059. When numeric 306 is received (from ZNC on connection when away), WHOIS is requested on own nick using irc redirection to get the away message from numeric 301. Properly set away message is necessary for away bar item to actually show anything.
This implementation is not perfect because every 306 is followed by a WHOIS, even when using
/away
manually. Visually there's no difference but there is the added overhead of a single WHOIS request. Maybe additional conditions should be in place to only do the WHOIS when the 306 isn't the result of manual away change.Also I did not test with
away-notify
capability which maybe makes this WHOIS trickery unnecessary.