-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: setup for the project #172
Open
Paras-Wednesday
wants to merge
3
commits into
wednesday-solutions:master
Choose a base branch
from
Paras-Wednesday:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,16 @@ | ||
FROM golang:1.22-alpine3.19 AS builder | ||
RUN apk add build-base | ||
|
||
RUN mkdir /app | ||
ADD . /app | ||
|
||
WORKDIR /app | ||
# copy the go.mod and go.sum and download the dependency first | ||
# before copying the project | ||
COPY go.mod /app | ||
COPY go.sum /app | ||
RUN go mod download | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Optimize Docker build layers by merging RUN commands. The consecutive - RUN GOARCH=amd64 \
- GOOS=linux \
- CGO_ENABLED=0 \
- go mod vendor
- RUN go run ./cmd/seeder/main.go
- RUN go build -o ./output/server ./cmd/server/main.go
- RUN go build -o ./output/migrations ./cmd/migrations/main.go
- RUN go build -o ./output/seeder ./cmd/seeder/exec/seed.go
+ RUN GOARCH=amd64 GOOS=linux CGO_ENABLED=0 go mod vendor && \
+ go run ./cmd/seeder/main.go && \
+ go build -o ./output/server ./cmd/server/main.go && \
+ go build -o ./output/migrations ./cmd/migrations/main.go && \
+ go build -o ./output/seeder ./cmd/seeder/exec/seed.go
|
||
|
||
# NOW COPY the whole root project | ||
COPY . /app | ||
|
||
ARG ENVIRONMENT_NAME | ||
ENV ENVIRONMENT_NAME=$ENVIRONMENT_NAME | ||
RUN GOARCH=amd64 \ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ go install golang.org/x/lint/golint@latest | |
go install github.com/BurntSushi/toml/cmd/tomlv@latest | ||
go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest | ||
go install github.com/segmentio/golines@latest | ||
go install github.com/masahiro331/[email protected] | ||
|
||
touch .git/hooks/commit-msg | ||
echo "go-commitlinter" >> .git/hooks/commit-msg | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enforce version pinning in
apk add
commands to enhance security.Pinning versions of packages in
apk add
commands is crucial for ensuring the reproducibility and security of Docker builds.Also applies to: 29-30
Tools
Hadolint