Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix docker publish workflow. #2555

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Shaun-Fong
Copy link

@Shaun-Fong Shaun-Fong commented Jul 2, 2023

Description

Problems with the current publishing workflow NETWORK SOCKET TIMEOUT

image
Image From

When I replaced it with [email protected] it ran successfully.

This PR should fix this problem.

Refs: #2454


🚀 This description was created by Ellipsis for commit 6231285

Summary:

This PR simplifies the Docker publishing workflow in .github/workflows/docker.yml by using manusa/[email protected], addressing network socket timeout issues.

Key points:

  • Replaced multiple Docker setup steps with manusa/[email protected] in .github/workflows/docker.yml
  • Simplified Docker image publishing process
  • Aimed to fix network socket timeout issues during Docker publishing

Generated with ❤️ by ellipsis.dev

@CLAassistant
Copy link

CLAassistant commented Jul 2, 2023

CLA assistant check
All committers have signed the CLA.

@huan
Copy link
Member

huan commented Jul 31, 2023

Thanks for creating this PR to fix the Docker build process!

Could you please confirm that the new fix still supports the ARM platform?

We were using QEMU before because we will build our docker image with different platforms so that we can use the Wechaty docker image on a Raspberry Pi.

@huan
Copy link
Member

huan commented May 3, 2024

Hey @ellipsis, give me a code review

Copy link

ellipsis-dev bot commented May 3, 2024

OK! Reviewing this PR...


Responding to this comment by @huan. For more information about Ellipsis, check the documentation.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 3, 2024
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Reviewed the entire pull request up to 6231285
  • Looked at 35 lines of code in 1 files
  • Took 40 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 0 additional comments because they didn't meet confidence threshold of 50%.

Workflow ID: wflow_NIAPgHGJB9grqlke


You can customize Ellipsis with review rules, user-specific overrides, quiet mode, and more. See docs.

6 days left in your free trial, upgrade for $20/seat/month or contact us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants