Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat at all #2418

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Feat at all #2418

wants to merge 2 commits into from

Conversation

hcfw007
Copy link
Member

@hcfw007 hcfw007 commented May 17, 2022

@huan
Copy link
Member

huan commented May 17, 2022

Could you please also add a unit test to see the behavior of the new method?

Thank you very much!

@hcfw007
Copy link
Member Author

hcfw007 commented May 17, 2022

Could you please also add a unit test to see the behavior of the new method?

Thank you very much!

This PR will require changes in wechaty-puppet first. @huan Could you confirm that this design is fine with you? Becuase I find it not very elegant.

this.wechaty.puppet.roomAnnounce(
      this.id,
      finalText,
      false,
      metionList.map(c => c.id)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants