Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix json-rpc-peer.d.ts definition #2034

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lhr0909
Copy link

@lhr0909 lhr0909 commented Aug 8, 2020

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added
  • CI has been passed. (GitHub actions all turns green)
  • SLA has been signed

Description

please describe the changes that you are making, with the related issue number.

This resolved #2026 .

@huan
Copy link
Member

huan commented Aug 8, 2020

It's great to receive this PR!

Please check the CI and make it green first, so that we can be able to inspect it later.

Thank you very much!

@huan
Copy link
Member

huan commented Aug 18, 2020

ping @lhr0909

Please let me know if you still want to work on this PR, and if so I'd like to continue our discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build when Wechaty is taken as a dependency
2 participants