Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] silk to pcm and wav #340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[docs] silk to pcm and wav #340

wants to merge 1 commit into from

Conversation

iftaken
Copy link

@iftaken iftaken commented Jul 4, 2022

There is a bug in pysilk converting silk to wav, it is recommended to use pilk, first convert silk to pcm, and then use ffmepg to convert to wav format

@iftaken iftaken requested a review from a team as a code owner July 4, 2022 11:56
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #340 (d96f31d) into master (e96706c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #340   +/-   ##
=======================================
  Coverage   41.50%   41.50%           
=======================================
  Files          27       27           
  Lines        1930     1930           
=======================================
  Hits          801      801           
  Misses       1129     1129           
Flag Coverage Δ
unittests 41.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Jul 4, 2022

Thanks for your contribution and improvement, can you add some description about what you have done in this pr, so that other developers can get it quickly.

Copy link
Collaborator

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You have udpated the solution for transformation between silk and wav file. Thanks for your contribution.

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Jul 5, 2022

The final process, you should sign the cla license so that I can merge the pr.

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Jul 5, 2022

Wechaty Contributors Nomination

Link to wechaty/PMC#16

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Jul 5, 2022

@iftaken please fix the conflicts.

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Jul 6, 2022

ping @iftaken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants