Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reply image && Add reply URL #234

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

shiyu22
Copy link

@shiyu22 shiyu22 commented Jul 12, 2021

Calling msg.say(hd_file_box) will report an error Wechaty - ERROR - internal error <'utf-8' codec can't decode byte 0xff in position 0: invalid start byte>, but reading the image from local file will fix it.

Also, added an example to the reply URL, vaild for WeChat articles.

@shiyu22 shiyu22 requested a review from a team as a code owner July 12, 2021 07:00
@CLAassistant
Copy link

CLAassistant commented Jul 12, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You find the problem:

Calling msg.say(hd_file_box) will report an error `Wechaty - ERROR - internal error <'utf-8' codec can't decode byte 0xff in position 0: invalid start byte>`, but reading the image from local file will fix it.

Also, added an example to the reply URL, vaild for WeChat articles.

Can you find the reason of this problem or post another pr to fix it ? Hoping your futher work.

examples/ding-dong-bot-oop.py Show resolved Hide resolved
@huan
Copy link
Member

huan commented Jul 12, 2021

Link to wechaty/PMC#16

Copy link
Collaborator

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many strict code style, which is crucial for wechaty opensource community.

examples/ding-dong-bot-oop.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants