refactor: migrate to property section label #4017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New property label is used for section titles.
|
We also have a bug, where section butttons don't do anything but still show a button-label 
Can we get that fix along this? |
|
Yep, finally figured |
JayaKrishnaNamburu
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Looks good and working as expected, one thing i noticed is the tooltip descriptions for some sections need to be moved to be used from property-value-descriptions instead of the current static texts. I will take care of it in #3964
kof
pushed a commit
that referenced
this pull request
Aug 30, 2024
Ref #3914 New property label is used for section titles. <img width="359" alt="Screenshot 2024-08-27 at 21 18 25" src="https://github.com/user-attachments/assets/681cf4d8-c124-45e0-9a9b-6914d12cc838">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #3914
New property label is used for section titles.