Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Little builder improvements from feedback #3914

Closed
9 of 10 tasks
kof opened this issue Aug 9, 2024 · 1 comment
Closed
9 of 10 tasks

Little builder improvements from feedback #3914

kof opened this issue Aug 9, 2024 · 1 comment
Assignees
@kof
Labels
complexity:medium Up to 1 week of work prio:1 The most important thing to work on type:bug Something isn't working

Comments

@kof
Copy link
Member

kof commented Aug 9, 2024 •
edited
Loading

@kof kof added type:bug Something isn't working complexity:medium Up to 1 week of work prio:1 The most important thing to work on labels Aug 9, 2024
@kof kof self-assigned this Aug 9, 2024
This was referenced Aug 10, 2024
Merged
Merged
kof added a commit that referenced this issue Aug 11, 2024
@kof
fix: Stop wrapping icon with the label (#3918)
403d7b2 
Part of #3914

## Description

Clicking on info icon page settings was resulting in input focus,
because it was inside the label

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
This was referenced Aug 11, 2024
Merged
Merged
kof added a commit that referenced this issue Aug 12, 2024
@kof
fix: fix blinking navigator item focus ring (#3919)
1c7cfe1 
Part of #3914


## Description

when clicking on collapsible trigger, previously focused item blinks if
we don't click event propagation


https://github.com/user-attachments/assets/f31507a3-8ccd-4ef2-97d4-590563724351


## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
kof added a commit that referenced this issue Aug 12, 2024
@kof
feat: add shift/option modifiers to spacing and position input popove…
939a2b8 
…rs (#3924)

Part of #3914

## Description

To allow entering a value from keyboard for all or opposite sides in
spacing and position controls, we now support same modifiers as we use
for drag guesture

## Steps for reproduction

1. open spacing
2. click on padding top number to open input
3. enter value, hold option or shift modifiers, then press enter
4. option places the value into opposite values, top/bottom, left/right,
shift changes all sides

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
kof added a commit that referenced this issue Aug 13, 2024
@kof
feat: tolerate comma instead of dot typo in style value input (#3926)
f7c02b2 
Part of #3914

## Description

Users often type comma instead of dot when entering css value numbers,
we want to auto convert them to dot.

## Steps for reproduction

1. type 1,2 in width input
2. hit enter, see it was converted to 1.2
3. type 1,2rem
4. hit enter, see it was converted to 1.2 and rem unit was applied

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
@johnsicili
Copy link
Contributor

johnsicili commented Aug 14, 2024 •
edited
Loading

when changing ephemeral styles of the border and outline property - hide the outline to let user see it

Super glad someone brought this up!

@kof kof mentioned this issue Aug 26, 2024
Merged
7 tasks
@TrySound TrySound mentioned this issue Aug 27, 2024
Merged
TrySound added a commit that referenced this issue Aug 28, 2024
@TrySound
refactor: migrate to property section label (#4017)
1643fcd 
Ref #3914

New property label is used for section titles.

<img width="359" alt="Screenshot 2024-08-27 at 21 18 25"
src="https://github.com/user-attachments/assets/681cf4d8-c124-45e0-9a9b-6914d12cc838">
kof added a commit that referenced this issue Aug 28, 2024
@kof
fix: hide outline when ephemeral update is in progress (#4011)
98cb2ef 
Ref #3914
Closes #3800

## Description
This allows to see borders/outlines when changing ephimeral styles e.g.
scrubbing border-outline width or color

This is not 100% fixing the problem, as you still can't see the
border/outline when you change non ephimeral value, but there is not
much we can actually do, because outline has to be blue for clarity,
making it look like the user color, would be potentially very confusing.

## Steps for reproduction

1. change any ephimeral styles like padding drag/drop or scrub any input
2. see outline is hidden during that change

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
kof pushed a commit that referenced this issue Aug 30, 2024
@TrySound @kof
refactor: migrate to property section label (#4017)
a78f7b7 
Ref #3914

New property label is used for section titles.

<img width="359" alt="Screenshot 2024-08-27 at 21 18 25"
src="https://github.com/user-attachments/assets/681cf4d8-c124-45e0-9a9b-6914d12cc838">
kof added a commit that referenced this issue Aug 30, 2024
@kof
fix: hide outline when ephemeral update is in progress (#4011)
460331b 
Ref #3914
Closes #3800

## Description
This allows to see borders/outlines when changing ephimeral styles e.g.
scrubbing border-outline width or color

This is not 100% fixing the problem, as you still can't see the
border/outline when you change non ephimeral value, but there is not
much we can actually do, because outline has to be blue for clarity,
making it look like the user color, would be potentially very confusing.

## Steps for reproduction

1. change any ephimeral styles like padding drag/drop or scrub any input
2. see outline is hidden during that change

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
@kof kof closed this as completed Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kof kof

Labels
complexity:medium Up to 1 week of work prio:1 The most important thing to work on type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kof @johnsicili