[ice] Fix unhandled overflow panic in listen_udp_in_port_range
#719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l panic due to overflow in debug, or silent overflow in release When `port_start` is assigned the value `u16::MAX`, and the socket cannot be bound to port `u16::MAX`, an unhandled overflow will occur. When building webrtc-rs using the debug profile, this overflow will lead to a panic, and worse yet in the release profile, a silent overflow and wrap around will occur, allowing `listen_udp_in_port_range` to bind to a port outside of the specified port range.
lucamuscat
force-pushed
the
fix-potential-panic-in-listen-udp
branch
from
8e38cd0 to
286368a
Compare
lucamuscat
commented
Aug 22, 2025
| }; | ||
|
|
||
| port_current += 1; | ||
| port_current = port_current.checked_add(1).unwrap_or(i); |
Contributor
Author
There was a problem hiding this comment.
If an overflow were to occur when incrementing port_current, we should wrap around to port_min instead of panicing on debug or wrapping around to zero on release.
rainliu
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
port_startis assigned the valueu16::MAX, and the socket cannot be bound to portu16::MAX, an unhandled overflow will occur.When building webrtc-rs using the debug profile, this overflow will lead to a panic, and worse yet in the release profile, a silent overflow and wrap around will occur, allowing
listen_udp_in_port_rangeto bind to a port outside of the specified port range.