Skip to content

devex: Refactor syntax-input and link-selector-table into form controls #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented May 5, 2025

Follows #2561
Resolves #2577
WIP #2536

Changes

Refactors <btrix-syntax-input> and <btrix-link-selector-table> to be form-associated controls.

Manual testing

  1. Log in as crawler
  2. Regression test "Link Selectors" table, verifying that validation and editing values works as expected.

@SuaYoo SuaYoo changed the title devex: Refactor devex: Refactor syntax-input and link-selector-table into form controls May 5, 2025
@SuaYoo SuaYoo requested review from emma-sg and ikreymer May 5, 2025 22:04
@SuaYoo SuaYoo marked this pull request as ready for review May 5, 2025 22:05
@SuaYoo SuaYoo force-pushed the frontend-data-grid-component branch from 12cd3f2 to a2936ed Compare May 7, 2025 02:09
@SuaYoo SuaYoo force-pushed the frontend-data-grid-component--elementinternals branch from 203fbec to 724eb25 Compare May 7, 2025 02:20
@SuaYoo SuaYoo force-pushed the frontend-data-grid-component--elementinternals branch from 724eb25 to e90cff0 Compare May 7, 2025 02:24
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but looks good overall!

@SuaYoo SuaYoo merged commit f90f25c into frontend-data-grid-component May 8, 2025
27 checks passed
@SuaYoo SuaYoo deleted the frontend-data-grid-component--elementinternals branch May 8, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants