Pause / Resume Crawls Initial Implmentation. #2572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2025
ikreymer
force-pushed
the
pause-resume
branch
3 times, most recently
from
dc2d462 to
1259990
Compare
This was
linked to
issues
May 1, 2025
SuaYoo
reviewed
May 5, 2025
SuaYoo
approved these changes
May 14, 2025
tw4l
approved these changes
May 14, 2025
- add 'pause' crawl state
- turns off crawler pods, and then redis pod when paused
- add 'paused' on crawl spec to indicate when crawl is paused
- /crawl/<id>/{un}pause apis to toggle 'paused' on crawl spec
- ui: add pause/resume button, paused state
- ui: add pausing/unpausing derivative states when crawl is running and pausing, or paused and not pausing
- Hide "Pause" button if it's not relevant, instead of disabling without a displayed reason - Make "Resume" button primary - Use circular icons to match other status icons - Show toast message on successful pause/unpause
- set <crawlid>:paused key when a crawl is paused and at least one crawler pod exists - clear <crawlid>:paused when crawl is paused and more pods running ensure flag is cleared before redis is shutdown, already cleared when a crawl is unpaused
- stop crawls that have been paused for too long - add 'paused_crawl_limit_minutes' to Helm chart - add paused time and expiry to crawlconfig API response - set to 'stopped_pause_expired' state - ui: add support for 'Stopped: Paused Too Long' for stopped_pause_expired - use 'paused_at' in CrawlJob to indicate crawl is paused and when
…vious versions of crawler: - set :stopping key to true - when crawler pod exits, immediately reset done -> interrupted - clear :stopping key when all crawler pods have exited OR crawl not longer paused (to allow resume)
…se, except actual derived 'pausing' state in frontend ensure resources are available for paused state
…eted' after being paused, goes to running state update - set state to 'pause' only when all crawler pods are paused - log 'pausing' on first change, don't recheck stopping if already set
Member
Author
|
Had to do some additional refactoring, switching back to using :paused key, supporting only newer crawler versions, otherwise duplicate data is uploaded. Also cleans up the implementation a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on #2566
Fixes #2576
pausedstate to workflow #2567)Todo: