Pause / Resume Crawls Initial Implmentation. #2572
Conversation
ikreymer
force-pushed
the
pause-resume
branch
3 times, most recently
from
dc2d462 to
1259990
Compare
| const disablePause = | ||
| this.workflow.lastCrawlPausing === | ||
| (this.workflow.lastCrawlState === "running"); |
There was a problem hiding this comment.
Should this just be checking lastCrawlPausing?
| const disablePause = | |
| this.workflow.lastCrawlPausing === | |
| (this.workflow.lastCrawlState === "running"); | |
| const disablePause = this.workflow.lastCrawlPausing; |
There was a problem hiding this comment.
I think the idea was that the button is both Pause / Resume, and possible states are:
- pausing and running (disable, already in process of Pausing)
- pausing and not running (don't disable, it should show Resume)
- not pausing and not running (disable, already in process of Resuming)
- not pausing and running (don't disable, it should show Pause)
Had to double check that, perhaps a bit more confusing then it needs to be.. maybe should rename it to disablePauseResume to be more clear
There was a problem hiding this comment.
The lastCrawlPausing / pausing reflects if user requested crawl to be paused/not paused, while crawl state is the actual state the crawl is in, so we enable the button when they are different.
There was a problem hiding this comment.
Yeah a variable rename would work, hidePauseResume and disablePauseResume.
Is there any need to add and check for lastCrawlResuming?
There was a problem hiding this comment.
Yeah a variable rename would work,
hidePauseResumeanddisablePauseResume.Is there any need to add and check for
lastCrawlResuming?
Resuming is the when lastCrawlPausing is set to false. I suppose it could be renamed too - if true, it means the user wants the crawl paused, if false, it means the user wants the crawl running/resumed (the default).
There was a problem hiding this comment.
Updated this to hidePauseResume and disablePauseResume. Also did a pass to replace instance of 'unpause' with 'resume', including in the API, to be consistent.
- add 'pause' crawl state
- turns off crawler pods, and then redis pod when paused
- add 'paused' on crawl spec to indicate when crawl is paused
- /crawl/<id>/{un}pause apis to toggle 'paused' on crawl spec
- ui: add pause/resume button, paused state
- ui: add pausing/unpausing derivative states when crawl is running and pausing, or paused and not pausing
- Hide "Pause" button if it's not relevant, instead of disabling without a displayed reason - Make "Resume" button primary - Use circular icons to match other status icons - Show toast message on successful pause/unpause
- set <crawlid>:paused key when a crawl is paused and at least one crawler pod exists - clear <crawlid>:paused when crawl is paused and more pods running ensure flag is cleared before redis is shutdown, already cleared when a crawl is unpaused
- stop crawls that have been paused for too long - add 'paused_crawl_limit_minutes' to Helm chart - add paused time and expiry to crawlconfig API response - set to 'stopped_pause_expired' state - ui: add support for 'Stopped: Paused Too Long' for stopped_pause_expired - use 'paused_at' in CrawlJob to indicate crawl is paused and when
…vious versions of crawler: - set :stopping key to true - when crawler pod exits, immediately reset done -> interrupted - clear :stopping key when all crawler pods have exited OR crawl not longer paused (to allow resume)
Work on #2566
Fixes #2576
pausedstate to workflow #2567)Todo: