rename for clarity, use resume instead of unpause consistently

Author: ikreymer

backend/btrixcloud/crawlmanager.py

@@ -389,7 +389,7 @@ async def shutdown_crawl(self, crawl_id: str, graceful=True) -> dict:
     async def pause_resume_crawl(
         self, crawl_id: str, paused_at: Optional[datetime] = None
     ) -> dict:
-        """pause or unpause a crawl"""
+        """pause or resume a crawl"""
         return await self._patch_job(
             crawl_id, {"pausedAt": date_to_str(paused_at) if paused_at else ""}
         )

backend/btrixcloud/crawls.py

@@ -772,7 +772,7 @@ async def get_crawl_stats(
     async def pause_crawl(
         self, crawl_id: str, org: Organization, pause: bool
     ) -> Dict[str, bool]:
-        """pause or unpause a crawl temporarily"""
+        """pause or resume a crawl temporarily"""
         crawl = await self.get_base_crawl(crawl_id, org)
         if crawl and crawl.type != "crawl":
             raise HTTPException(status_code=400, detail="not_a_crawl")
@@ -1284,11 +1284,11 @@ async def pause_crawl(crawl_id, org: Organization = Depends(org_crawl_dep)):
         return await ops.pause_crawl(crawl_id, org, pause=True)
 
     @app.post(
-        "/orgs/{oid}/crawls/{crawl_id}/unpause",
+        "/orgs/{oid}/crawls/{crawl_id}/resume",
         tags=["crawls"],
         response_model=SuccessResponse,
     )
-    async def unpause_crawl(crawl_id, org: Organization = Depends(org_crawl_dep)):
+    async def resume_crawl(crawl_id, org: Organization = Depends(org_crawl_dep)):
         return await ops.pause_crawl(crawl_id, org, pause=False)
 
     @app.post(

frontend/src/pages/org/workflow-detail.ts

@@ -563,11 +563,15 @@ export class WorkflowDetail extends BtrixElement {
 
     const archivingDisabled = isArchivingDisabled(this.org, true);
     const paused = workflow.lastCrawlState === "paused";
-    const hidePause =
+
+    const hidePauseResume =
       !this.lastCrawlId ||
       this.isCancelingOrStoppingCrawl ||
       this.workflow.lastCrawlStopping;
-    const disablePause =
+    // disable pause/resume button if desired state is already in the process of being set.
+    // if crawl is running, and already pausing, don't allow clicking Pausing
+    // if crawl not running, and already unpausing (lastCrawlPausing is false), don't allow clicking Resume
+    const disablePauseResume =
       this.workflow.lastCrawlPausing ===
       (this.workflow.lastCrawlState === "running");
 
@@ -577,12 +581,12 @@ export class WorkflowDetail extends BtrixElement {
         () => html`
           <sl-button-group>
             ${when(
-              !hidePause,
+              !hidePauseResume,
               () => html`
                 <sl-button
                   size="small"
-                  @click=${this.pauseUnpause}
-                  ?disabled=${disablePause}
+                  @click=${this.pauseResume}
+                  ?disabled=${disablePauseResume}
                   variant=${ifDefined(paused ? "primary" : undefined)}
                 >
                   <sl-icon
@@ -1680,14 +1684,14 @@ export class WorkflowDetail extends BtrixElement {
     }
   }
 
-  private async pauseUnpause() {
+  private async pauseResume() {
     if (!this.lastCrawlId) return;
 
     const pause = this.workflow?.lastCrawlState !== "paused";
 
     try {
       const data = await this.api.fetch<{ success: boolean }>(
-        `/orgs/${this.orgId}/crawls/${this.lastCrawlId}/${pause ? "pause" : "unpause"}`,
+        `/orgs/${this.orgId}/crawls/${this.lastCrawlId}/${pause ? "pause" : "resume"}`,
         {
           method: "POST",
         },
@@ -1702,7 +1706,7 @@ export class WorkflowDetail extends BtrixElement {
         message: pause ? msg("Pausing crawl.") : msg("Resuming paused crawl."),
         variant: "success",
         icon: "check2-circle",
-        id: "crawl-pause-unpause-status",
+        id: "crawl-pause-resume-status",
       });
     } catch {
       this.notify.toast({
@@ -1711,7 +1715,7 @@ export class WorkflowDetail extends BtrixElement {
           : msg("Something went wrong, couldn't resume paused crawl."),
         variant: "danger",
         icon: "exclamation-octagon",
-        id: "crawl-pause-unpause-status",
+        id: "crawl-pause-resume-status",
       });
     }
   }