This repository has been archived by the owner on Apr 22, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 6
Test improvements #63
Draft
okdistribute
wants to merge
6
commits into
webrecorder:master
Choose a base branch
from
okdistribute:test-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankiebee
reviewed
Sep 14, 2020
Python 2.x | ||
|
||
``` | ||
pip install pywb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not all computers come with pip
frankiebee
reviewed
Sep 14, 2020
test/status/README.md
Outdated
@@ -0,0 +1,35 @@ | |||
Prerequisites: | |||
|
|||
Python 2.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python not preinstalled on all os's
@ikreymer is their an email we can use for setting up a twitter account? |
@frankiebee Yes, good pint, created a new google group that can be used for this, sent an email to see if it worked. |
okdistribute
commented
Sep 23, 2020
echo $endlessloop_pid | ||
echo $1 | ||
../../node_modules/.bin/ava --verbose lib/one.js --match $1 | ||
# node lib/output-status.js $1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Enable this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This loads the script in puppeteer, next steps:
from @ikreymer
Twitter
Facebook