fix: adjust min-height for SplashViz component and clean up comments#7882
Closed
ShaikArsalan347 wants to merge 1 commit intowebpack:mainfrom
Closed
fix: adjust min-height for SplashViz component and clean up comments#7882ShaikArsalan347 wants to merge 1 commit intowebpack:mainfrom
ShaikArsalan347 wants to merge 1 commit intowebpack:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@ShaikArsalan347 i have actually opened the PR before, i think creating duplicate PRs is not efficient as it increases the maintainer's work and also wastes the time of other contributors |
Contributor
Author
|
@TusharThakur04 |
Contributor
|
yes maintainer are for helping if something goes wrong, its not like to open the new PR. |
Contributor
|
and i have just fixed it |
Contributor
Author
I apologize for the confusion and iam closing the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #7881 . Fixes remaining responsiveness issues in the Cube component and improves layout behavior on smaller viewports.
What kind of change does this PR introduce?
Style fix (layout / responsiveness improvements)
Did you add tests for your changes?
No — visual changes were verified manually across breakpoints.
Does this PR introduce a breaking change?
No.
Documentation
No additional documentation is required.