fix(a11y): fixed background contrast#7829
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@evenstensberg I have raised PRs to resolve all the issues of Lighthouse along with screenshots of them working fine. Some might still be showing It could be server caching but I have resolved all of them separately. |
| } | ||
|
|
||
| a { | ||
| text-decoration: underline; |
There was a problem hiding this comment.
do we need to always show underline to pass the audit rule?
There was a problem hiding this comment.
not always required. I added to make sure it passes audit. But I can move it to markdown only or use underline-on-hover if that's good with current design.
Does that sounds good?
|
@evenstensberg I made changes as I mentioned above but that has decreased the accessibility score to 88. Is there any other way to handle this? |
|
You will need to do some research, underline on all links is not pretty. |
|
@evenstensberg pls review, I have made some code changes to fix accessibility audit. Ran locally and now accessibility score is 96 
|
|
I dont like the text underline when they've not been visited. You need to do some research on how to have a11y pass without text-decoration. |
2 participants
Summary
Fixed Background and foreground colors do not have sufficient contrast ratio under Contrast issue in Lighthouse
What kind of change does this PR introduce?
Code changes
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
N/A