feat: bump to express 5

[bjohansebas]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Breaking Changes

Additional Info

While with Express there are hardly any changes other than adding support for some encodings or changing the regex path match, so nothing in the Express code will change for now. However, it is necessary to update http-proxy-middleware, since in version 2 they have a resolution to use Express 4, whereas version 3 of that package already allows a different version of Express and other packages. :)

[bjohansebas]

I still need to investigate why some content-types are not being changed, since JavaScript files are now "text/javascript", but somewhere that content-type is still not being updated, and also run the allowed-host tests.

[alexander-akait]

I still need to investigate why some content-types are not being changed, since JavaScript files are now "text/javascript", but somewhere that content-type is still not being updated, and also run the allowed-host tests.

Can you provide where?

It can be a problem in webpack-dev-middleware

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.29%. Comparing base (cc0b931) to head (ef8353d).

❗ There is a different number of reports uploaded between BASE (cc0b931) and HEAD (ef8353d). Click for more details.

HEAD has 3 uploads less than BASE

Flag	BASE (cc0b931)	HEAD (ef8353d)
	16	13

Additional details and impacted files

@@             Coverage Diff             @@
##             next    #5564       +/-   ##
===========================================
- Coverage   83.57%   69.29%   -14.28%     
===========================================
  Files          11       11               
  Lines        1966     1954       -12     
  Branches      735      729        -6     
===========================================
- Hits         1643     1354      -289     
- Misses        290      515      +225     
- Partials       33       85       +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bjohansebas]

Okay, the content-type issue was coming from webpack-dev-middleware, updating it fixed everything.

[bjohansebas]

Okay, after #5626 , I’ll debug this since there will be fewer tests to run.

[alexander-akait]

Feel free to merge when CI will be green

[bjohansebas]

Okay, the proxy-related tests are failing, so I’m going to look into the reason

edit: I found a small issue in the loggers, since they changed the system, so I’m working on updating it

[bjohansebas]

Even though it does respect level logger, it still calls the function, so I’ll need to use snapshots instead of checking whether the function was called like the current tests do. This happens when the logger is set to none, it doesn’t show the message, probably due to webpack’s internal logic, but it still calls it.