-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use methods to get client entries #5308
Merged
alexander-akait
merged 3 commits into
webpack:master
from
LingyuCoder:refactor/client-entry-methods
Sep 26, 2024
Merged
refactor: use methods to get client entries #5308
alexander-akait
merged 3 commits into
webpack:master
from
LingyuCoder:refactor/client-entry-methods
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
previously approved these changes
Sep 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5308 +/- ##
==========================================
- Coverage 90.29% 85.12% -5.18%
==========================================
Files 15 16 +1
Lines 1577 1741 +164
Branches 601 652 +51
==========================================
+ Hits 1424 1482 +58
- Misses 140 233 +93
- Partials 13 26 +13 ☔ View full report in Codecov by Sentry. |
alexander-akait
approved these changes
Sep 26, 2024
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
A test case was added in
test/e2e/client.test.js
to test that the override can take effect correctly.Motivation / Use-Case
Use methods to get client entries, so that users can introduce custom client entries instead by overriding these methods.
Breaking Changes
No breaking changes
Additional Info