Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Multiremote and fixed many errors of current main branch #602

Closed
wants to merge 5 commits into from

Conversation

SnakeDrak
Copy link

@SnakeDrak SnakeDrak commented Nov 19, 2021

I have added support for multiremote and custom driver when we use the elements or mock matchers. Also I have added some fixes for the current main branch, however the npm run test:types is causing issues yet due to external library types. I will fix them in another PR.

It should fix or use as workaround for issue 106.

UPDATED: Types fixed as well.

@linux-foundation-easycla
Copy link

CLA Not Signed

1 similar comment
@linux-foundation-easycla
Copy link

CLA Not Signed

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SnakeDrak for the work on this and sorry for the late reply.

I just pushed a commit that might help avoid all the @ts-ignore comments in the PR. I rather would like to avoid them.

@@ -1,9 +1,11 @@
{
"compilerOptions": {
"outDir": "dist",
"lib": ["ES2018"],
"lib": ["ES2018", "DOM"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this.

@christian-bromann
Copy link
Member

Also can you explain how this patch will enable multiremote to work?

@SnakeDrak
Copy link
Author

@christian-bromann I did it some month ago and I don't remember the full details. However, the original idea was to be able to pass the driver where you want to check. You could use something like:

expect(myInput).toHaveAttribute('class', 'form-control', browser)
expect(myInput).toHaveAttribute('class', 'md-form-control', app)

I remember the master branch was broken and I tried to fix it as well, for that reason you see some extra commits. At this moment, I am using my fork with this feature to support multiples driver at the same instance and to be able to test correctly each one.

You can check the tests included to know if it has a sense for you. Most probably I would have to update against master again.

@christian-bromann
Copy link
Member

@SnakeDrak is there any interest to push this PR forward?

@pwespi
Copy link

pwespi commented Jun 24, 2022

Is there anything I can do to help pushing this forward? I would like to see the multiremote feature land in expect-webdriverio.

@lacell75
Copy link
Contributor

Any news?

@christian-bromann
Copy link
Member

@lacell75 as you can see, no. Would you like to pick this up?

@christian-bromann
Copy link
Member

I will go ahead and close this as the branch starts to diverge to much from main. I would be happy for any contributions making this library compatible with multiremote.

Thanks for the work you put into this @SnakeDrak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants