Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the resources dir if it doesn't exist #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lloydpick
Copy link

And just re-use the helper method for the sparkle config dir

@webcracy
Copy link
Owner

Thanks @lloydpick!

I assumed the resources/ folder was part of the default template; is my assumption bust?

I'll review this PR to see if I can refactor some of this config stuff, then I'll pull your fix in.

Cheers

@lloydpick
Copy link
Author

My project didn't start from the default template, so I didn't have one, which meant it failed to write the public key, it just happily carried on going.

@webcracy
Copy link
Owner

Got it, thanks for the info! I'll update the issue after my review.

@YesThatAllen
Copy link

Hi @webcracy is this PR, about a missing resources folder good to merge?

@webcracy
Copy link
Owner

@YesThatAllen Is this problem affecting you at the moment? This PR should work according to my review, but I didn't want to merge it "as is" for a reason I don't recall right now. I was going to change it a bit, but haven't yet.

@YesThatAllen
Copy link

The fix is working for us, yes. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants