-
Notifications
You must be signed in to change notification settings - Fork 62
[scorpio]: Fix bug in overlayfs & init LFS code #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Han Xiaoyang <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Han Xiaoyang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 18 out of 33 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- scorpio/script/.gitignore: Language not supported
- scorpio/src/dicfuse/tree_store.rs: Evaluated as low risk
- scorpio/src/passthrough/logfs.rs: Evaluated as low risk
- scorpio/src/manager/push.rs: Evaluated as low risk
- scorpio/src/manager/store.rs: Evaluated as low risk
- scorpio/src/main.rs: Evaluated as low risk
- scorpio/src/overlayfs/tempfile.rs: Evaluated as low risk
- scorpio/src/fuse/inode_alloc.rs: Evaluated as low risk
- scorpio/README.md: Evaluated as low risk
- scorpio/src/fuse/mod.rs: Evaluated as low risk
- scorpio/src/dicfuse/mod.rs: Evaluated as low risk
- scorpio/src/overlayfs/async_io.rs: Evaluated as low risk
- scorpio/src/manager/fetch.rs: Evaluated as low risk
- scorpio/src/lib.rs: Evaluated as low risk
- scorpio/config.toml: Evaluated as low risk
Comments suppressed due to low confidence (3)
scorpio/script/log_analysis.py:24
- The first compiled regex pattern is not used and should be removed to avoid redundancy.
uuid_regex = re.compile(...)
scorpio/src/passthrough/async_io.rs:139
- Debugging statement should be replaced with proper logging.
println!("readdir:{}",name.to_str().unwrap());
scorpio/src/daemon/lfs.rs:147
- The
size_human
field should be set only ifparams.size
isSome(true)
. Consider usingparams.size.unwrap_or(false)
to ensure that the field is set correctly.
size_human: params.size.then(|| "15.2 MB".to_string())
Signed-off-by: Han Xiaoyang <[email protected]>
Head branch was pushed to by a user without write access
01d5d62
link to #857 and #865