-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] implements setImmediate and remove its polyfill #6624
Conversation
Signed-off-by: Marin Petrunic <[email protected]>
Co-authored-by: Muhammad Altabba <[email protected]>
Deploying with Cloudflare Pages
|
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6624 +/- ##
==========================================
- Coverage 91.46% 90.39% -1.08%
==========================================
Files 214 215 +1
Lines 8155 8263 +108
Branches 2193 2222 +29
==========================================
+ Hits 7459 7469 +10
- Misses 696 794 +98
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
Description
Implements
setImmediate
and remove its polyfills.By the way, the
setImmediate
polyfills was added only insideweb3-eth
. ButsetImmediate
was used in bothweb3-eth
andweb3-utils
.Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.