-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stress Tests 3 - create long duration ws tests #6588
Conversation
Deploying with
|
Latest commit: |
fef8fe2
|
Status: | ✅ Deploy successful! |
Preview URL: | https://4dd42370.web3-js-docs.pages.dev |
Branch Preview URL: | https://5564.web3-js-docs.pages.dev |
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6588 +/- ##
==========================================
+ Coverage 87.37% 89.57% +2.19%
==========================================
Files 197 215 +18
Lines 7548 8276 +728
Branches 2059 2242 +183
==========================================
+ Hits 6595 7413 +818
+ Misses 953 863 -90
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. we need to have a convention regarding file structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good alex,
However, I have just 2 comments, in addition to Junaid comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
However, would like to have the webpage test done with cypress. Also in the readme, you wrote test:manual
but currently there is no command with this exact name. Do you plan to have this in another MR which would contain multiple manual tests?
Description
Stress Tests ( These tests should be automated but not integrated in github CI actions, so we can invoke these tests locally any time when required )
Keeping the connection open for a longer duration of time (10 hours manual test) and sending request after some constant interval ( 10 min ) at end of test time display number of requests failed if any or connection interrupted. This test can be done on some testnet Infura endpoint.
Stress Tests 3 - QA Tests #5564
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.