Skip to content

Commit

Permalink
fixed ethereum hashing standard typo (#6735)
Browse files Browse the repository at this point in the history
  • Loading branch information
Santiago Trujillo Zuluaga authored Jan 23, 2024
1 parent 727c9fc commit b49094b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/web3-eth-accounts/src/account.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export const parseAndValidatePrivateKey = (data: Bytes, ignoreLength?: boolean):
/**
*
* Hashes the given message. The data will be `UTF-8 HEX` decoded and enveloped as follows:
* `"\\x19Ethereum Signed Message:\\n" + message.length + message` and hashed using keccak256.
* `"\x19Ethereum Signed Message:\n" + message.length + message` and hashed using keccak256.
*
* @param message - A message to hash, if its HEX it will be UTF8 decoded.
* @returns The hashed message
Expand Down

1 comment on commit b49094b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: b49094b Previous: 6c075db Ratio
processingTx 9471 ops/sec (±4.28%) 9301 ops/sec (±4.81%) 0.98
processingContractDeploy 39889 ops/sec (±7.47%) 39129 ops/sec (±7.62%) 0.98
processingContractMethodSend 19452 ops/sec (±7.91%) 19443 ops/sec (±5.19%) 1.00
processingContractMethodCall 39025 ops/sec (±6.24%) 38971 ops/sec (±6.34%) 1.00
abiEncode 45479 ops/sec (±6.71%) 44252 ops/sec (±6.92%) 0.97
abiDecode 31701 ops/sec (±8.24%) 30419 ops/sec (±8.89%) 0.96
sign 1629 ops/sec (±3.83%) 1656 ops/sec (±4.08%) 1.02
verify 376 ops/sec (±0.58%) 373 ops/sec (±0.78%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.