Skip to content

Commit

Permalink
Fix typos (#6708)
Browse files Browse the repository at this point in the history
* fix typos
  • Loading branch information
omahs authored Jan 29, 2024
1 parent aac2420 commit 7d7a9ea
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Further details about versioning can be found in the [semver 2.0.0 specification

`E2E Network Tests` will be triggered to run via a Github workflow when a PR is open for a branch prefixed with `release/` and is being merged into `4.x` branch. These tests depend on a couple of ENVs to be set that are configurable in Github's Action Secrets when running these tests in CI. The following required secrets are:

- `E2E_TESTS_ALLOWED_SEND_TRANSACTION`: If set to `false` this will keep the Sepolia tests that spend ETH from runnning, setting to anything else will cause them to run
- `E2E_TESTS_ALLOWED_SEND_TRANSACTION`: If set to `false` this will keep the Sepolia tests that spend ETH from running, setting to anything else will cause them to run
- `TEST_ACCOUNT_PRIVATE_KEY`: The private key of the Sepolia account to use when submitting transactions
- `INFURA_SEPOLIA_HTTP`: The provider to be used to access the Sepolia network
- `INFURA_MAINNET_HTTP`: The provider to be used to access Mainnet
Expand Down Expand Up @@ -54,7 +54,7 @@ Further details about versioning can be found in the [semver 2.0.0 specification

- Select recently pushed tag in `choose a tag` drop down

- Check `Set as the latest release` if its latest release else select `This is a pre-release` if its not main release e.g. if its `RC` or `alpha`
- Check `Set as the latest release` if its latest release else select `This is a pre-release` if it's not main release e.g. if it's `RC` or `alpha`

- Check `Create a discussion for this release`

Expand Down
2 changes: 1 addition & 1 deletion docs/docs/guides/web3_eth/eth.md
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ transactionHash {
98999580000000000000 + 1000000000000000000 + (20000000000\*21000) = 100 Ether
:::

In the next example, we are going to use `estimateGas` function to see the expected gas for contract deployment. (For more on contracts, please see the corresponding tutotial). Create a file named `estimate.ts` and fill it with the following code:
In the next example, we are going to use `estimateGas` function to see the expected gas for contract deployment. (For more on contracts, please see the corresponding tutorial). Create a file named `estimate.ts` and fill it with the following code:

```typescript
import { Web3, ETH_DATA_FORMAT, DEFAULT_RETURN_FORMAT } from 'web3';
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/guides/web3_plugin_guide/plugin_authors.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ It is important to note that the plugin name should be structured as `@<organiza
}
```

When your users install your plugin, this will allow the package manager to make use of the user installed `web3` if available and if the version satisfies the version constraints instead of installing it's own version of `web3`.
When your users install your plugin, this will allow the package manager to make use of the user installed `web3` if available and if the version satisfies the version constraints instead of installing its own version of `web3`.

## Add New Transaction Type

Expand Down
2 changes: 1 addition & 1 deletion packages/web3-eth-accounts/test/unit/tx/legacy.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ describe('[Transaction]', () => {
expect(tx.r!.toString(16)).toBe('5');
});

it('Initialization -> throws when creating a a transaction with incompatible chainid and v value', () => {
it('Initialization -> throws when creating a transaction with incompatible chainid and v value', () => {
let common = new Common({ chain: Chain.Goerli, hardfork: Hardfork.Petersburg });
let tx = Transaction.fromTxData({}, { common });
expect(tx.common.chainId()).toEqual(BigInt(5));
Expand Down
2 changes: 1 addition & 1 deletion packages/web3-validator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ yarn add web3-validator

### Usage

You can use the the validator by importing as and using to validate;
You can use the validator by importing as and using to validate;

```ts
import { validator } from 'web3-validator';
Expand Down
2 changes: 1 addition & 1 deletion packages/web3/test/integration/contract.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import {
jest.mock('web3-eth');

describe('Contract', () => {
describe('Contract use the the context wallet', () => {
describe('Contract use the context wallet', () => {
it('should work when created as web.eth.Contract', async () => {
const web3 = new Web3('https://rpc2.sepolia.org');
const contract = new web3.eth.Contract(
Expand Down

1 comment on commit 7d7a9ea

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 7d7a9ea Previous: 6c075db Ratio
processingTx 9255 ops/sec (±5.67%) 9301 ops/sec (±4.81%) 1.00
processingContractDeploy 36452 ops/sec (±7.33%) 39129 ops/sec (±7.62%) 1.07
processingContractMethodSend 17294 ops/sec (±9.90%) 19443 ops/sec (±5.19%) 1.12
processingContractMethodCall 37216 ops/sec (±7.61%) 38971 ops/sec (±6.34%) 1.05
abiEncode 42885 ops/sec (±8.38%) 44252 ops/sec (±6.92%) 1.03
abiDecode 28286 ops/sec (±9.30%) 30419 ops/sec (±8.89%) 1.08
sign 1635 ops/sec (±1.04%) 1656 ops/sec (±4.08%) 1.01
verify 371 ops/sec (±0.56%) 373 ops/sec (±0.78%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.