Usage treshold & severity levels #358
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbuerk
reviewed
Sep 26, 2024
| */ | ||
| private function formatNumber(int $number): string | ||
| { | ||
| return number_format($number, 0, ',', '.'); |
There was a problem hiding this comment.
Using the NumberFormatter would be nicer, however that requires php intl which is only hard required by the TYPO3 core since v12.
There was a problem hiding this comment.
Yes indeed, since this would take local language settings into account. But as you said, the requirement does not exist in TYPO3 11 and adding this to the package only for this one number format seems to be a disproportionate burden for integrators. Suggestion: Merge this format for now, keep a migration to NumberFormatter:: on a short list for your next version?
Action icons dont have a fixed color set, in order to let TYPO3 set the desired color - black in list actions, white in toolbar infos. Change the DeepL SVG to not use black in all places.
Calculate the message severity based on the API quota usage rate. Matching popular quota warning levels if will notify above 90% usage, and shown an error when the limit is exceeded. Hide the flashmessage after a translation if the severity is low. Refs web-vision#343
Use severity levels in widget as well and reduce the height to prevent unused whitespace.
pixelbrackets
force-pushed
the
usage-flashmessage-treshold
branch
from
e537b55
to
86ac206
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on formating styles in PR #357 and the desire for a threshold in issue #343 I have
tweaked the severity level determination in all usage bars (flashmessage, system infobox, widget).
Based on warning levels in other software (90%, 98%, 100%) each info box will use a different
severity color according to the currently used quota.
The widget is a bit more compact now, since it used a lot of whitespace before,
which makes the dashboard unnecessary large.