Skip to content

Commit

Permalink
webrtc wpt: add test for direction-based filtering of codecs
Browse files Browse the repository at this point in the history
to supplement the discussion in
  w3c/webrtc-pc#2937

BUG=324930413

Change-Id: Iebf02aade64030e11590af211fa7bc90f976c592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5293562
Commit-Queue: Philipp Hancke <[email protected]>
Reviewed-by: Harald Alvestrand <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1262367}
  • Loading branch information
fippo authored and marcoscaceres committed Feb 23, 2024
1 parent a99b7c3 commit 8974b15
Showing 1 changed file with 79 additions and 0 deletions.
79 changes: 79 additions & 0 deletions webrtc/protocol/codecs-filtered-by-direction.https.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
<!doctype html>
<meta charset=utf-8>
<meta name="timeout" content="long">
<title>RTCPeerConnection Codecs in offer get filtered by direction</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="../third_party/sdp/sdp.js"></script>
<script>
'use strict';

function codecEquals(c1, c2) {
return c1.mimeType === c2.mimeType &&
c1.sdpFmtpLine === c2.sdpFmtpLine &&
c1.clockRate === c2.clockRate &&
c1.channels === c2.channels;
}

function splitCodecs() {
const sendCodecs = RTCRtpSender.getCapabilities('video').codecs;
const receiveCodecs = RTCRtpReceiver.getCapabilities('video').codecs;
const codecs = {
sendrecv: [],
sendonly: [],
recvonly: [],
};
// Ignore RTX since it is present in capabilities once and has no apt.
for (const receiveCodec of receiveCodecs) {
if (receiveCodec.mimeType === 'video/rtx') continue;
if (sendCodecs.find(sendCodec => codecEquals(sendCodec, receiveCodec))) {
codecs.sendrecv.push(receiveCodec);
}
}

for (const sendCodec of sendCodecs) {
if (sendCodec.mimeType === 'video/rtx') continue;
if (!receiveCodecs.find(receiveCodec => codecEquals(sendCodec, receiveCodec))) {
codecs.sendonly.push(sendCodec);
}
}
for (const receiveCodec of receiveCodecs) {
if (receiveCodec.mimeType === 'video/rtx') continue;
if (!sendCodecs.find(sendCodec => codecEquals(sendCodec, receiveCodec))) {
codecs.recvonly.push(receiveCodec);
}
}
return codecs;
}

promise_test(async t => {
const pc = new RTCPeerConnection();
t.add_cleanup(() => pc.close());

const allCodecs = splitCodecs();
const transceiver = pc.addTransceiver('video');

transceiver.direction = 'sendonly'
const offer = await pc.createOffer();
const mediaSection = SDPUtils.getMediaSections(offer.sdp)[0];
const rtpParameters = SDPUtils.parseRtpParameters(mediaSection);
const sendonlyCodecs = rtpParameters.codecs.filter(c => c.name !== 'rtx');
assert_equals(sendonlyCodecs.length, allCodecs.sendrecv.length + allCodecs.sendonly.length);
}, 'Codecs get filtered by direction for sendonly');

promise_test(async t => {
const pc = new RTCPeerConnection();
t.add_cleanup(() => pc.close());

const allCodecs = splitCodecs();
const transceiver = pc.addTransceiver('video');

transceiver.direction = 'recvonly'
const offer = await pc.createOffer();
const mediaSection = SDPUtils.getMediaSections(offer.sdp)[0];
const rtpParameters = SDPUtils.parseRtpParameters(mediaSection);
const recvonlyCodecs = rtpParameters.codecs.filter(c => c.name !== 'rtx');
assert_equals(recvonlyCodecs.length, allCodecs.sendrecv.length + allCodecs.recvonly.length);
}, 'Codecs get filtered by direction for recvonly');

</script>

0 comments on commit 8974b15

Please sign in to comment.