Skip to content

Commit

Permalink
Use only sign() function and don't mark tests as tentative
Browse files Browse the repository at this point in the history
The sign() function is already speced, so without progress() the
tests should not be marked tentative.

Bug: 41494232
Change-Id: I8ba597670028749d9a76cc97ddf8e4e2befc7781
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5307215
Commit-Queue: Daniil Sakhapov <[email protected]>
Reviewed-by: Anders Hartvoll Ruud <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1262345}
  • Loading branch information
danielsakhapov authored and marcoscaceres committed Feb 23, 2024
1 parent d6c3f5e commit a99b7c3
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<title>border-image-width interpolation with css math functions</title>
<link rel="author" title="Daniil Sakhapov" href="mailto:[email protected]">
<link rel="help" href="https://drafts.csswg.org/css-backgrounds/#the-border-image-width">
<link rel="help" href="https://drafts.csswg.org/css-values/#sign-funcs">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/css/support/interpolation-testcommon.js"></script>
Expand Down Expand Up @@ -32,7 +33,7 @@
test_interpolation({
property: 'border-image-width',
from: 'calc(sign(20rem - 20px) * 100)',
to: 'calc(progress(10rem from 20px to 100px) * 180)',
to: 'calc(sign(20rem - 20px) * 180)',
}, [
{at: -1, expect: '20'},
{at: 0, expect: '100'},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<meta charset="utf-8">
<title>font-size-adjust interpolation with css math functions</title>
<link rel="help" href="https://drafts.csswg.org/css-fonts-5/#font-size-adjust-prop">
<link rel="help" href="https://drafts.csswg.org/css-values/#sign-funcs">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/css/support/interpolation-testcommon.js"></script>
Expand Down Expand Up @@ -32,7 +33,7 @@
test_interpolation({
property: 'font-size-adjust',
from: 'calc(sign(20rem - 20px) * 100)',
to: 'calc(progress(10rem from 20px to 100px) * 180)',
to: 'calc(sign(20rem - 20px) * 180)',
}, [
{at: -1, expect: '20'},
{at: 0, expect: '100'},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<meta charset="utf-8">
<title>font-size-adjust interpolation with css math functions</title>
<link rel="help" href="https://drafts.csswg.org/css-fonts-5/#font-size-adjust-prop">
<link rel="help" href="https://drafts.csswg.org/css-values/#sign-funcs">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/css/support/interpolation-testcommon.js"></script>
Expand Down Expand Up @@ -32,7 +33,7 @@
test_interpolation({
property: 'font-stretch',
from: 'calc(sign(20rem - 20px) * 100%)',
to: 'calc(progress(10rem from 20px to 100px) * 180%)',
to: 'calc(sign(20rem - 20px) * 180%)',
}, [
{at: -1, expect: '20%'},
{at: 0, expect: '100%'},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
<html>
<head>
<meta charset="utf-8">
<title>angle custom properties interpolation with progress-*() functions</title>
<title>angle custom properties interpolation with css math functions</title>
<link rel="author" title="Daniil Sakhapov" href="mailto:[email protected]">
<link rel="help" href="https://drafts.csswg.org/css-values-5/#progress">
<meta name="assert" content="angle custom properties support interpolation with progress-*() functions.">
<link rel="help" href="https://drafts.csswg.org/css-values/#sign-funcs">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/css/support/interpolation-testcommon.js"></script>
Expand Down Expand Up @@ -38,7 +37,7 @@
test_interpolation({
property: '--my-angle',
from: 'calc(sign(20rem - 20px) * 100deg)',
to: 'calc(progress(10rem from 20px to 100px) * 180deg)',
to: 'calc(sign(20rem - 20px) * 180deg)',
}, [
{at: -1, expect: '20deg'},
{at: 0, expect: '100deg'},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<title>offset-rotate interpolation with css math functions</title>
<link rel="author" title="Daniil Sakhapov" href="mailto:[email protected]">
<link rel="help" href="https://drafts.fxtf.org/motion-1/#offset-rotate-property">
<link rel="help" href="https://drafts.csswg.org/css-values-5/#progress">
<link rel="help" href="https://drafts.csswg.org/css-values/#sign-funcs">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/css/support/interpolation-testcommon.js"></script>
Expand Down Expand Up @@ -33,7 +33,7 @@
test_interpolation({
property: 'offset-rotate',
from: 'calc(sign(20rem - 20px) * 100deg)',
to: 'calc(progress(10rem from 20px to 100px) * 180deg)',
to: 'calc(sign(20rem - 20px) * 180deg)',
}, [
{at: -1, expect: '20deg'},
{at: 0, expect: '100deg'},
Expand Down

0 comments on commit a99b7c3

Please sign in to comment.