perf: Optimize test history memory usage#4887
Open
DanielRyanSmith wants to merge 2 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the memory efficiency and execution time of the
testHistoryHandlerby removing expensive map allocations.Root Cause / Motivation
Previously, the test history API modeled each subtest entry as a
map[string]string. When processing historical records for a test suite across multiple browsers, instantiating thousands of small maps incurs massive memory overhead, high garbage collection pressure, and slow allocation speeds compared to standard Go structs.Detailed Changelog
api/test_history.go: RefactoredSubtestfrom amap[string]stringto a strongly-typedstructwith JSON tags. This drastically reduces heap allocations and memory fragmentation when assembling the final JSON response tree.api/test_history_test.go: Updated the unit test assertions to match the newSubteststruct format.