Fix WebDriver timeout in TestQueryBuilder_MasterCheckedForMasterLabelQuery#4872
Open
DanielRyanSmith wants to merge 1 commit intomainfrom
Open
Fix WebDriver timeout in TestQueryBuilder_MasterCheckedForMasterLabelQuery#4872DanielRyanSmith wants to merge 1 commit intomainfrom
DanielRyanSmith wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a flaky timeout error in the
TestQueryBuilder_MasterCheckedForMasterLabelQueryWebDriver test running on Firefox.Root Cause / Motivation
The test previously used
FindShadowElement, which eagerly resolved the<wpt-app>element and passed it across multiple Javascript executions via Geckodriver to find the#master-checkboxinside the nested Shadow DOM oftest-runs-query-builder. In Firefox, referencing this element before the Custom Element Polyfill finished upgrading it caused Geckodriver to fail to locate the nested element, leading to the 30-second timeout.Detailed Changelog
webdriver/builder_test.go: Replaced theFindShadowElementcall with a directExecuteScriptRawinvocation that evaluatesdocument.querySelector('wpt-app')and its corresponding Shadow DOM down to the#master-checkboxin a single Javascript execution. It returns the element array forDecodeElements, ensuring the browser always queries the live DOM state and avoids stale references.