Skip to content

fix: make color-backtrace optional for release #10717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Jun 18, 2025

Summary

since we use abort panic=abort in release and it will not generate meaningful backtrace, so color-backtrace seems meanless and can be removed for release profile to reduce binary size.
we can also enable panic = unwind for dev profile to help debugging panic problem in development environment

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jun 18, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 10c20dc
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6854f26e4621c80008842ce6

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jun 18, 2025
@hardfist hardfist marked this pull request as ready for review June 18, 2025 10:31
@hardfist hardfist force-pushed the yj/make-backtrace-optional branch from 16f8958 to 902f915 Compare June 18, 2025 14:12
Copy link

codspeed-hq bot commented Jun 18, 2025

CodSpeed Performance Report

Merging #10717 will not alter performance

Comparing yj/make-backtrace-optional (10c20dc) with main (9e4d78f)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 16 untouched benchmarks

@hardfist hardfist force-pushed the yj/make-backtrace-optional branch from 902f915 to f62b77f Compare June 19, 2025 02:43
@hardfist hardfist force-pushed the yj/make-backtrace-optional branch from f62b77f to 10c20dc Compare June 20, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant