Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance the rule of project name and the check logic of project root #34

Merged
merged 1 commit into from
Dec 5, 2023
Merged

enhance the rule of project name and the check logic of project root #34

merged 1 commit into from
Dec 5, 2023

Conversation

NingW101
Copy link
Contributor

@NingW101 NingW101 commented Dec 5, 2023

to close #32 & #33

@NingW101 NingW101 requested a review from lingyuncai December 5, 2023 07:27
lingyuncai
lingyuncai approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@lingyuncai lingyuncai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Ning~

@NingW101 NingW101 merged commit 019b6a8 into web-devkits:main Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingyuncai lingyuncai lingyuncai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The project name can not be named with uppercase letters
2 participants
@NingW101 @lingyuncai