Enhance documents #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Sep 10, 2024
| /* from the export_func->signature, parse and prepare the arguments array(argv1) */ | ||
| ... | ||
|
|
||
| /* lookup the quick aot entry, basically it will reinterpret the function ptr type that will match export_func->signature */ |
There was a problem hiding this comment.
lookup_quick_aot_entry is provided by wasm_application.c and is static. Developer must link the libcvmlib.a, but we suppose that he doesn't have to link it.
Suggest to just convert the func_ptr to an function according the prototype, and call it directly, like:
typedef int32 (*AOTFunc)(int32);
AOTFunc aot_func = (AOTFunc)export_func->func_ptr;
int32 result = aot_func(..);
wenyongh
reviewed
Sep 10, 2024
|
|
||
| ... | ||
|
|
||
| if (!app_instance_func(func_name)) |
There was a problem hiding this comment.
don't call app_instance_func, it is also provided in wasm_application.c and suppose not to be linked in some scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.