Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: optimize the logic of determining whether a file is a standard library #109

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

Shanks0224
Copy link
Contributor

Currently, the file names of the standard library are defined in advance: lib.type.d.ts and lib_builtin.ts.
If the user-defined file name is included in the absolute path string of the standard library file, then the custom file is considered to be a standard library file.
At this time, if we use the standard library function in the custom file, such as console.log, an error that the 'console' definition cannot be found will be reported.

Copy link
Contributor

@xujuntwt95329 xujuntwt95329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xujuntwt95329 xujuntwt95329 merged commit 783e9af into web-devkits:main Dec 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants