benchmark: add benchmark validation #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kylo5aby
commented
Dec 14, 2023
kylo5aby
commented
- add benchmark result validation
- parse wamr options by array
kylo5aby
force-pushed
the
benchmark/validation
branch
from
1f77f46 to
6fa5a1a
Compare
| let end = performance.now(); | ||
| elapsed = (end - start); | ||
| elapse_arr.push(elapsed); | ||
| ret = ret.toString().trim(); |
There was a problem hiding this comment.
Had better also check the return code of the process
Signed-off-by: zhenweijin <[email protected]>
kylo5aby
force-pushed
the
benchmark/validation
branch
from
6fa5a1a to
63b0ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.