feat: add webauthn signal api serializers #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what to do with the failing checks, because some checks are failing on files I didn't touch. |
|
Hi, Many thanks. I was not aware of these signals. I read the documentation carefully and it looks really interesting. I will investigate the failing tests. |
Spomky
force-pushed
the
feat-add-webauthn-signal-api
branch
from
a8d3e78 to
28f2c06
Compare
Introduced `Signal` interface along with three implementations: `AllAcceptedCredentials`, `CurrentUserDetails`, and `UnknownCredential`. Added corresponding denormalizers to handle serialization and deserialization of these events, updating `WebauthnSerializerFactory` to register them. Extended `SerializerTest` to validate proper functionality with new test cases.
Spomky
force-pushed
the
feat-add-webauthn-signal-api
branch
from
28f2c06 to
6cb08b5
Compare
Expanded the PHPStan baseline to include new warnings related to type handling and offset accessibility in Signal denormalizers (`SignalAllAcceptedCredentialsDenormalizer`, `SignalCurrentUserDetailsDenormalizer`, and `SignalUnknownCredentialDenormalizer`), ensuring accurate tracking of static analysis issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch: 5.3.x
Resolves issue: n/a
The WebAuthn Signal API is a new extension to WebAuthn that allows servers and clients to exchange additional “signal” data in a privacy-preserving way, enabling scenarios such as passkey upgrade flows, security key cross-device operations, seamless migration, and more. See the W3C explainer and Chrome Developer Docs.
This pull request introduces new denormalizers and corresponding signal classes to support WebAuthn serialization for the Signal API. These changes handle three signals:
AllAcceptedCredentials,CurrentUserDetails, andUnknownCredential.