Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

add wait check for task.Kill(cc.ctx, syscall.SIGQUIT) #931

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Giles2000
Copy link

when stop the container timeout,ignite will kill the container's task by syscall and delete the killed task.
In practice,kill task will takes a little time to finish (maybe a few hundred milliseconds),
but delete func does not wait for the kill task to complete. It immediately starts checking that the container's task is not running and tries to delete it.
but now,before kill task has completed , the container's task is still running. Therefore, the delete function cannot successfully delete the container.even after a few hundred milliseconds, the container has stopped

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant