Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add OCI tool choice #571

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add OCI tool choice #571

wants to merge 1 commit into from

Conversation

bbros-dev
Copy link

Only alters kernel build scripts.
Preserves existing behavior.
Defaults to docker when podman is not available.

Tested as working via make

Signed-off-by: Begley Brothers Inc [email protected]

Signed-off-by: Begley Brothers Inc <[email protected]>
@bbros-dev bbros-dev requested a review from twelho as a code owner April 1, 2020 04:50
if ! [ -x "$(command -v podman)" ]; then
oci_tool=podman
else
oci_tool=docker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch 👋

Would DOCKER=podman make build be sufficient for you?
This would be consistent with the main Makefile we already have.

Other usage would be:
DOCKER="sudo docker" make build

The kernel build helper scripts would also need to be modified to use this ENV var to override docker.
We could do a followup PR if you don't have the bandwidth to do so.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries: DOCKER=podman. Will try get to that this week and force update this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants