优化serializer #5
Open
优化serializer #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
为什么要单独把serializer分出来？ 建议如果需要进行格式化的话还是要设定一个具体的类型比较好 |
我发现定义了serializer，但type名不包含Option，居然就不生效，这样是不合适的。 |
|
可以讲下你的使用场景？ 或者提供下示例 |
relation:
- table: user_list
column:
dialogue_style:
serializer: json
type: "[]Style"model目录下已经定义了Style，serializer: json是无效的 |
|
如果type配置成[]Style, 一是扩展性不好，二是还需要配置这个Style需要导入的包，反而会比较麻烦。 建议使用 type DialogueStyle []Style{} 或者 type DialogueStyle struct{ List []Style }, 这种方式后续扩展性比较好，配置也简单 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.