Remove KELOD Banner code #436
Conversation
| // KELOD research banner campagin 2024 Q1 - https://phabricator.wikimedia.org/T357667 | ||
| // Visible until March 24th 2024 00:00:00 UTC) | ||
| if (time() < mktime(0, 0, 0, 3, 24, 2024)) { | ||
| wfLoadExtension( 'DismissableSiteNotice' ); |
There was a problem hiding this comment.
This raises the question if we now shall also remove the extension?
|
Thanks for making this PR. I think Frederik raised good questions and I guess I lean towards removing the extension again, because if I remember correctly, for future use we wanted to solve this differently. But it's hard to say, my crystal ball is currently out of order 🔮 I could also live with only this conf removed |
|
Do we still want to do this? |
|
both good questions I only bother to reply to after 4 months; I'd suggest we rip out the config and then also remove the extension. I think while there may be a little digging involved I'd hope that next time we have a banner ticket come in that at a minimum someone searches phabricator for "banner" and "wikibase.cloud" which ought to breadcrumb them into the correct place |
This code is already inactive since the deadline passed. Let's clean it up now
This code is already inactive since the deadline passed. Let's clean it up now