Expand usage of LimitWikiAccess middleware #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKostka
changed the title
tarrow
reviewed
May 27, 2025
| abort(403); | ||
| } | ||
|
|
||
| if (!$wikiManager->wiki) { |
There was a problem hiding this comment.
I suspect this block should be higher in the middleware; for any random non-existing wiki I think this middleware currently returns a 403 not 404
There was a problem hiding this comment.
This was the existing behavior, but I agree that it makes more sense to swap it around.
tarrow
reviewed
May 27, 2025
AndrewKostka
force-pushed
the
refactor-LimitWikiAccess
branch
from
f4cb4ea to
f1c4b8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: T394986