Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jquery.raty.js #233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

markvantilburg
Copy link
Contributor

Fixes #190

Copy link
Collaborator

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.eslintrc:
.eslintrc:
	Environment key "es2021" is unknown

Error: .eslintrc:
at Object.keys.forEach.env (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-validator.js:144:19)
at Array.forEach ()
at validateEnvironment (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-validator.js:140:30)
at Object.validate (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-validator.js:240:5)
at loadFromDisk (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:516:19)
at Object.load (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config.js:179:43)
at Config.getConfigVector (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config.js:286:21)
at Config.getConfig (/home/linters/app/versions/eslint-4.19.1/node_modules/eslint/lib/config.js:329:29)

@markvantilburg
Copy link
Contributor Author

Should also fix #177

@wbotelhos
Copy link
Owner

Hi @markvantilburg , thanks for your PR.
Could you add some tests? Do you know how to do that?

@markvantilburg
Copy link
Contributor Author

Maybe some information could be added to the readme on how to run and add tests indeed ;) I've got no idea.

@ReefmanKoen
Copy link

ReefmanKoen commented Nov 29, 2021

I think this fix is wrong, if score < 0 then on line 602 integer will evaluate to 0 and the line var star = this.stars[integer - 1]; will result in an error. I have tested and confirmed this locally the same way the original bug presented itself.
Edit: additionally I have found the issue to present itself with a score above the max as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome: Uncaught TypeError: Cannot set property 'src' of undefined
4 participants