Skip to content

Provide a source and javadoc artifacts #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

stadler
Copy link

@stadler stadler commented Jan 31, 2018

Add maven sources plugin, update maven javadoc plugin and drop obsolete JVM parameter

Fixes #19

@wbadam
Copy link
Owner

wbadam commented May 8, 2018

Hi, thank you for the pull request.

I've eventually used the maven release plugin to create the correct files which was included in the Viritin archetype, just wasn't used before.

If you think it still makes sense to include javadoc and source plugins as part of the normal build process (it might), it should be investigated if these and the release plugin collide in any way.

@stadler
Copy link
Author

stadler commented May 24, 2018

Hi
I think the sources and javadoc makes still sense, as users of your library will be able to see the actual sources and/or javadoc. So it does not collide but rather complement the release process.
I changed those plugins to be only part of the release process.
I also adapted the javadoc plugin to not fail the build if there are javadoc problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants