-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: 404 Error Page Redesign #476 and #480 #665
base: main
Are you sure you want to change the base?
Conversation
No issues detected, please do a thorough human review. |
@@ -1,80 +1,119 @@ | |||
.not-found { | |||
.not-found-page { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's an article about sass nesting to control scope if you want to go that route
https://css-tricks.com/using-sass-control-scope-bem-naming/
Here's some examples in our code base of what it looks like:
https://github.com/waterthetrees/wtt_front/blob/main/client/src/components/Button/Button.scss
background-color: #EEEEEE; | ||
} | ||
|
||
@media (max-width: 900px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the media query breakpoints we've been using:
320px — 480px: Mobile devices
481px — 768px: iPads, Tablets
769px — 1024px: Small screens, laptops
1025px — 1200px: Desktops, large screens
1201px and more — Extra large screens, TV
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks for making this happen!!
Added a few minor css change requests.
Also, if you can please add a test, that will be great!
Here's an simple example of a snapshot test:
https://github.com/waterthetrees/wtt_front/blob/main/client/src/tests/WttButton.test.js
More test examples here:
https://github.com/waterthetrees/wtt_front/blob/main/client/src/tests
Feel free to either put it in the test folder or in this Notfound folder to be closer this page. You can run it like this:
npm test -- -u NotFound.test.js
Hi @zhiyanz How's this going? Are you still working on this? |
Thanks for getting back. No rush on this. If you are still interested in finishing it up after May 15, great thanks! |
I will continue working on it after May 15. Thanks for your understanding! @zoobot |
@zoobot is this complete? |
Tickets: #476 and #480
What has changed:
Screenshots: