-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature:-About Page Redesign #270 #403
Draft
vernfongchao
wants to merge
14
commits into
main
Choose a base branch
from
vernfongchao/feature/about/redesign
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
69abece
Redign About Page
vernfongchao 0559200
remove all but montserrat regular
vernfongchao f8eae6b
change fontSize span
vernfongchao 233720a
remove WET css code on page container component
vernfongchao 6a500cc
add marginTop about 64px
vernfongchao 986b8df
merge with main
vernfongchao 3878376
refractored from style components to css
vernfongchao d9c9de7
-m
vernfongchao 7eee5fe
remove about us header
vernfongchao 3bf16ce
fix margins on number section
vernfongchao fbb22a5
fix image size
vernfongchao 0e35357
fixed footer position
vernfongchao 7c8118a
removed unused files
vernfongchao c582ca2
removed width typo from about.scss file
vernfongchao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import React from 'react'; | ||
import styled from '@emotion/styled'; | ||
|
||
export const GreenButton = styled.button((props) => ({ | ||
background: '#3fab45', | ||
color: 'white', | ||
fontSize: '1.75rem', | ||
border: 'none', | ||
borderRadius: '.5rem', | ||
...props.styles, | ||
})); | ||
|
||
export default GreenButton; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import React from 'react'; | ||
|
||
export const Affiliates = (props) => { | ||
const affiliates = [ | ||
{ | ||
city: 'Alameda', | ||
link: 'https://www.alamedaca.gov/Departments/Public-Works-Department/Street-Trees', | ||
logo: 'https://www.acpwa.org/acpwa-assets/img/pwa-logo-2color-2.png', | ||
}, | ||
{ | ||
city: 'Oakland', | ||
link: 'https://www.oaklandca.gov/services/oak311', | ||
logo: 'https://cao-94612.s3.us-west-2.amazonaws.com/resources/wj_city_pw_logo_black_OL.jpg', | ||
}, | ||
{ | ||
city: 'San Francisco', | ||
link: 'https://friendsoftheurbanforest.formtitan.com/f0a646a51519754097160#/', | ||
logo: 'https://static.wixstatic.com/media/e4f6ab_cc7774e849d1432f88e48f2cbfa3f2af~mv2.png/v1/fill/w_240,h_216,al_c,q_85,usm_0.66_1.00_0.01,enc_auto/FUF%20logo_rgb.png', | ||
}, | ||
{ | ||
city: 'San Francisco', | ||
link: 'https://sf311.org/services/tree-maintenance', | ||
logo: 'https://www.sfpublicworks.org/sites/default/files/pwlogo_0.png', | ||
}, | ||
]; | ||
|
||
return ( | ||
<> | ||
{affiliates?.map((affiliate) => ( | ||
<a | ||
key={affiliate.link} | ||
href={affiliate.link} | ||
target="_blank" | ||
rel="noopener noreferrer" | ||
> | ||
<img src={affiliate.logo} alt="affiliates" /> | ||
</a> | ||
))} | ||
{props.children} | ||
</> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export * from './Affiliate'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like it can be simplified. Why is there a nesting of a
position: absolute
inside of aposition: relative
div? Is there a way to collapse the number of divs and the number of classname selectors?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why im having an absolute nesting inside of a relative is mainly for structure. The relative div is used to give structure but also control to its children divs. Its actually a well known technique used by alot of people. It allows me to manipulate the position and have it be relatives to its current flow instead of the html page
https://css-tricks.com/absolute-positioning-inside-relative-positioning/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so the relative element gives structuring for the absolute element child. But there is just one child that doesn't have any positioning fields like
top
,left
, etc, so I'm not sure why you need this extra div element. Couldn't you put these fields into the parent&__relative
element? I could be wrong!