Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main.wasp polish #134

Merged
merged 2 commits into from
May 22, 2024
Merged

main.wasp polish #134

merged 2 commits into from
May 22, 2024

Conversation

Martinsos
Copy link
Member

I did a bunch of small improvements to main.wasp and grouped them all in this one PR!

@Martinsos Martinsos requested a review from vincanger May 21, 2024 21:27
* https://wasp-lang.dev/docs/data-model/entities
*/

entity User {=psl
id Int @id @default(autoincrement())
createdAt DateTime @default(now())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all entities, I grouped fields and ordered them so that most generic ones go first (id, createdAt), then go important relations like user + userId and similar, and then go business logic fields.

@@ -179,6 +207,7 @@ page LandingPage {
component: import LandingPage from "@src/client/landing-page/LandingPage"
}

//#region Auth Pages
Copy link
Member Author

@Martinsos Martinsos May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be coming out in the new version of Wasp's vscode plugin, allowing you to collapse the region of the file.

Copy link
Collaborator

@vincanger vincanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like!

@vincanger vincanger merged commit 1623575 into main May 22, 2024
1 check passed
@Martinsos Martinsos deleted the main-wasp-polish branch May 22, 2024 12:35
Martinsos added a commit that referenced this pull request Jun 4, 2024
* Polished small things in main.wasp.

* Polished many small things in main.wasp file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants