Fix #460 (leak) m3_FreeModule now free memoryExportName and table0ExportName #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=33554. The OSS-Fuzz inputs led to a crash on a Const64 instruction that overflows the stack. The overflow was not detected during compilation as TouchSlot did not track maxStackSlots if o->function is NULL. This commit changes TouchSlot to track slots outside of functions.
While pushing the params back onto the stack in CompileBlock, GetSlotForStackIndex may return c_slotUnused. If that is the case, passing the slot to MarkSlotsAllocatedByType leads to a crash. Fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=33555 Fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=36551
In the case of an exception in CompileElseBlock, the original page was not properly restored and was leaked. This commit moves the release/restore in the _catch: block which always executes.
When the stack is polymorphic, the stack should never underflow. This commits fixes an unreported stack underflow while led to an integer underflow in stackIndex. Now, if the stack is polymorphic, we only decrement stackIndex up until blockStackIndex.
Issue wasm3#321: This replaces `intValue` in the global value union with separate `i32Value` and `i64Value`. A CI test is added against s390x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an old fork such that the history might not be so clean and it includes some small unrelated changes. Let me know if this is important to you st. I can create a new PR. :)