Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement faster* BE ABI #456

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SoniEx2
Copy link

@SoniEx2 SoniEx2 commented Dec 19, 2023

We wanted to make wasm3 faster for compute-heavy workloads on big-endian platforms. We can do this by changing the ABI.

Notes: wasi implementation has not been updated for this ABI (wasi tests fail completely), CI has not been updated to run any tests for this ABI but spec tests pass locally.

@vshymanskyy
Copy link
Member

I guess this borrows the idea from Wasm2C, which stores the whole linear memory in reverse order?

@SoniEx2
Copy link
Author

SoniEx2 commented Dec 28, 2023

yeah, that was the idea... maybe it'd be too much of a maintenance burden tho, sorry. >.<

@vshymanskyy
Copy link
Member

The idea is great. However, to merge it, we must make it compatible (syntax wise) with the existing imported C functions syntax. I'm not sure if this is possible...

@vshymanskyy
Copy link
Member

Oh, looks like it doesn't need any API changes on the Little Endian systems.
It just needs some adjustments of the WASI functions that peek directly into the memory (i.e. we need to reverse strings!).
Am I missing something?

@SoniEx2
Copy link
Author

SoniEx2 commented Dec 28, 2023

nah, that's pretty much all there is to it, but that's where we ran into #457 and gave up, the changes seemed really big and unapproachable >.<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants