Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: IAM RDS auth to sql components and refactor #168

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

add: IAM RDS auth to sql components and refactor #168

wants to merge 6 commits into from

Conversation

gregfurman
Copy link
Collaborator

Changes

  • Refactors how AWS components are imported -- allowing for Bento distros without the AWS SDK to compile and use SQL components.
  • Adds support for generating an IAM authentication token for RDS.
  • Some more refactoring to make both secret manager and IAM approaches better integrated.

TODO

@gregfurman gregfurman self-assigned this Feb 14, 2025
@gregfurman gregfurman marked this pull request as ready for review February 14, 2025 15:13
jem-davies
jem-davies approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@jem-davies jem-davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gregfurman
gregfurman commented Feb 22, 2025
View reviewed changes
internal/impl/sql/conn_fields.go
Comment on lines +116 to +117
service.NewStringField("secret_name").
Description("An optional field that can be used to get the Username + Password from AWS Secrets Manager. This will overwrite the Username + Password in the DSN with the values from the Secret only if the driver is set to `postgres`.").
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jem-davies We should make a note that this field has changed to within the aws config section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jem-davies jem-davies jem-davies approved these changes

Assignees

@gregfurman gregfurman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregfurman @jem-davies